Fix upper bound of the scale in SUEP shower simulation #43165
Conversation
|
@cmsbuild , please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43165/37485
|
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@mkirsano, @alberto-sanchez, @menglu21, @bbilin, @GurpreetSinghChahal, @SiewYan can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4d96f/35553/summary.html Comparison SummarySummary:
|
|
diffs in MsgLogger only, as expected |
|
Hi @tvami which slide shows the difference between with and w/o the fix |
|
hi @menglu21 there is no plot before the fix, Pythia simply crashes for the higher T samples. For example slide 15, T=5GeV I understand has already been problematic. |
|
+1 |
cmsbuild
added
generators-approved
fully-signed
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
@cms-sw/orp-l2 if you have the chance to merge this today, I'll get started doing the backports and hopefully by done by OPR next week |
|
+1 |
PR description:
SUEP simulations have a bug with the upper bound of the scale to be fixed at 2.0, this PR fixes that (credit to @cericeci).
The change was validated by the analysis team and private samples were shown at
https://indico.cern.ch/event/1157541/#24-suep-signal-details
Now they are requesting official samples so we need it in CMSSW.
PR validation:
This PR has no effect on bkg samples, or most of the signal samples, it's only relevant to SUEP showers with Pythia. See the link above for the validation by analysts.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Should be backported to both 12_4_X (for Run-3 samples) and 10_6_X (for UL)